angular-ui/ui-grid

rowSearcher.stripTerm messes up the searchTerm

Open

#4,733 opened on Nov 19, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

So I set my col.filters[0].term with a custom filterTemplate to a string like 2015-01-01. Now I though this should work, however, it turns out that when the term gets passed into the condition function, it looks like this: 2015\-01\-01.

The problem seems to lie in rowSearcher#stripTerm, where escapeRegExp is called on the term when the term is a string.

Can anyone explain the logic behind this to me? The description of the function only states that stripTerm "Remove leading and trailing asterisk (*) from the filter's term". However, it obviously does way more. Also, the defined return value is the jsdoc is incorrect as the term is returned an not an int value representing the condition.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptunderstanding of regexfamiliarity with AngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is in the rowSearcher.stripTerm function in src/js/core/services/rowSearcher.js. The function incorrectly calls escapeRegExp on the term, which escapes dashes. To fix, remove the escapeRegExp call or apply it only when needed. Consider reviewing the function's purpose (removing leading/trailing asterisks) and adjusting accordingly. Also update the jsdoc to reflect actual behavior.
rowSearcher.stripTerm messes up the searchTerm · angular-ui/ui-grid#4733 | Good First Issue