angular-ui/ui-grid

ui-grid-disable-selection

Open

#4,728 opened on Nov 18, 2015

View on GitHub
 (3 comments) (1 reaction) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

This CSS class is getting applied when I enable row selection (or full row selection). When this class is applied, hovering over the row does NOT show the cursor: pointer; style like I think it should.

Why is this css class getting applied? is this in error?

Contributor guide

Tech stack
javascriptcsshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the ui grid source code to understand when the class 'ui grid disable selection' is applied during row selection. Look at the CSS rules defined for this class and the JavaScript logic that toggles it. The fix likely involves either adding 'cursor: pointer' to the CSS rule for that class when selection is enabled, or adjusting the logic so the class is not applied in that scenario. Check the rowSelection feature files and related CSS.
ui-grid-disable-selection · angular-ui/ui-grid#4728 | Good First Issue