angular-ui/ui-grid

Pagination breaks when items per page is changed to 25 from 10 and user was on last page

Open

#4,713 opened on Nov 17, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Upon selecting pagination option as 10 items per page and switching to 15th page;then changing the pagination to 25 items per page, the page count on right hand side breaks. It shows NaN - NaN of 144 items.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the pagination logic in the grid component. The bug occurs when changing items per page while on a page that exceeds the new maximum page count. Look at the pagination calculation functions, possibly in files like 'Grid.js' or 'pagination.js'. Ensure that the current page index is recalculated or clamped to the new max page when items per page changes.