angular-ui/ui-grid

Tooltip error when column type == 'date'

Open

#4,709 opened on Nov 16, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

On this line (9277), the CUSTOM_FILTERS is concatenated to the tooltip, and that makes an error. template = template.replace(uiGridConstants.TOOLTIP, 'title="{{' + tooltipCall + ' CUSTOM_FILTERS }}"');

This is the output HTML:

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with AngularJSUnderstanding of ui grid templating
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The bug is in the template replacement at line 9277 (likely in the main source file). The CUSTOM FILTERS constant is being concatenated directly, causing invalid HTML in the title attribute. The fix should ensure proper escaping or use a different template syntax. Investigate how other filters are applied in the tooltip generation code and check for existing unit tests for date column tooltips.
Tooltip error when column type == 'date' · angular-ui/ui-grid#4709 | Good First Issue