angular-ui/ui-grid

RowSorter cache is global for all grids

Open

#4,683 opened on Nov 12, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

RowSorter’s colSortFnCache is global for all grids.

The first time a column sort function is found using getSortFn it will cached using the column name as a key. This cached function will be used for any other columns with the same name throughout the app.

I would not expect the configuration of one grid to have this global effect.

Contributor guide

Research direction
Identify the global cache in RowSorter's colSortFnCache and refactor it to be per grid instance. Ensure each grid has its own cache to avoid cross grid interference.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55