angular-ui/ui-grid

RowSorter cache is global for all grids

Open

#4,683 opened on Nov 12, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

RowSorter’s colSortFnCache is global for all grids.

The first time a column sort function is found using getSortFn it will cached using the column name as a key. This cached function will be used for any other columns with the same name throughout the app.

I would not expect the configuration of one grid to have this global effect.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of AngularJSFamiliarity with ui grid sorting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is caused by a global cache colSortFnCache in ui grid that uses column name as key. To fix, make the cache per grid instance, for example by storing it in the grid's scope or using a WeakMap keyed by the grid. Look at the sorting logic in the source code to identify where the cache is populated and accessed.