angular-ui/ui-grid

column resizing when filtering creates new set of comments in HTML DOM on each key pressed

Open

#4,672 opened on Nov 11, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This plunk: http://plnkr.co/edit/vMaDCAbJMc2nSC59qVkT

Try filtering Gender column... Inspect DOM in Chrome (for example) under div role="columnheader" of that column, a lot of HTML comments are added, like this <!-- ngIf: grid.options.enableColumnResizing -->

On each keystroke, a new set of comments is added.

DOM manipulation such as this slows browsers

Contributor guide

Research direction
Investigate the column resizing directive's interaction with filtering and how it adds HTML comments. Look for repeated compilation or DOM manipulation in the resize handler.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSDOM manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55