angular-ui/ui-grid

column resizing when filtering creates new set of comments in HTML DOM on each key pressed

Open

#4,672 opened on Nov 11, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performance

Description

This plunk: http://plnkr.co/edit/vMaDCAbJMc2nSC59qVkT

Try filtering Gender column... Inspect DOM in Chrome (for example) under div role="columnheader" of that column, a lot of HTML comments are added, like this <!-- ngIf: grid.options.enableColumnResizing -->

On each keystroke, a new set of comments is added.

DOM manipulation such as this slows browsers

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular ngIfDOM inspection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Reproduce the issue using the provided Plunkr. Inspect the DOM to verify the excess comment nodes. Look into the column resizing directive in the ui grid source (likely in files like 'ui grid column resizing' or related). The comments are generated by ngIf, suggesting the resizing directive is toggling visibility repeatedly on each keystroke. Investigate the filter logic that triggers re rendering and identify the cause of repeated ngIf evaluations. Consider whether a track by or one time binding could prevent unnecessary DOM updates.