angular-ui/ui-grid

Angular Material conflict

Open

#4,489 opened on Oct 7, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

Hi, my team and i found a bug wen using Angular Material and ui.grid.pagination, it seems that the pagination api override something in the angular core module ('ng' module to be precise) and Angular Material cease to work....

We found that if we remove the 'ng' dependency from the ui.grid.pagination module the problem stops, and still the pagination api still works (which is weird because that means that, that dependency is being import for nothing).

Anyway if some one out there can validate this too would be great and if u guys fix this issue it would be awesome.

Contributor guide

Tech stack
angularjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS experienceknowledge of ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue reports a conflict between Angular Material and ui.grid.pagination. The reporter found that removing the 'ng' dependency from the ui.grid.pagination module resolves the conflict. Investigate the pagination module's dependency on the 'ng' module and whether it is necessary. Look at the module definition in the ui grid source code, likely in the 'src' directory. Consider if removing the dependency breaks any functionality. There are no linked PRs or maintainer comments.