angular-ui/ui-grid

Custom sortingAlgorithm with large data set and virtualization

Open

#4,399 opened on Sep 18, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performancetype: FAQ

Description

I have a date column that is stored as a string in the JSON. In order to sort this, I'm using a custom sortingAlgorithm on the column with the following definition:

{
    displayName: 'Date Approved',
    field: 'dateApproved',
    sortingAlgorithm: function (aDate, bDate) {
        var a = moment(aDate);
        var b = moment(bDate);
        if (a < b) {
            return -1;
        }
        else if (a > b) {
             return 1;
        }
        else {
            return 0;
        }
    }
}

This seems to work great for the first chunk of data, but once I get beyond maybe 60 rows or so, it falls apart and the sorting becomes random. For this particular grid, I have about 600 rows, with a filter applied that shows about 100. Is this a known issue?

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of AngularJSFamiliarity with ui gridJavaScript date manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate ui grid's sorting and virtualization logic in the source code, specifically how the custom sortingAlgorithm interacts with the virtual scroll. The issue (~2015) may have been resolved in later versions; check the changelog and closed issues for related fixes. Look for any PRs or maintainer comments addressing sorting with large datasets. Also consider whether the issue stems from the sorting function itself or from data handling by the grid.