angular-ui/ui-grid

if rowIdentity is overriden, data changes are not detected properly

Open

#4,374 opened on Sep 15, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

Hi.

I encounter some difficulty with ui-grid 3.0.6, I'm new to it, so I did a lot of copy/paste, and I did copy a code chunk where rowIdentity is overriden.

From here: http://ui-grid.info/docs/#/tutorial/401_AllFeatures

When it's the case, and when I try to update a Row after a cellEdition, the new data are not being displayed event if you try some refresh(), refreshRows() or notifyDataChanges

in my init I have this

$scope.gridApi.edit.on.afterCellEdit($scope, $scope.saveARow)

And in my saveARow function I did something like this :

$scope.gridOptions.data[rowIndex] = newRow;

If rowIdentity is overriden, data are not diplayed See. http://plnkr.co/edit/tVRnVxcOfgO8xEHRWj00?p=preview

You'll have to edit a cell put whatever in it, it 'simulate' a call to a save server side, then replace te savedRow by what is present serverside after 3 seconds.

If you comment le rowIdentity override line 28 it will works

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid rowIdentity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the ui grid source code, specifically how rowIdentity affects data change detection. The provided plunkr (http://plnkr.co/edit/tVRnVxcOfgO8xEHRWj00?p=preview) demonstrates the bug. Focus on the code that handles cell edits and row updates. Check if there is a workaround or fix by modifying the rowIdentity function or by updating the grid data differently.