angular-ui/ui-grid

Save columns state not working

Open

#4,370 opened on Sep 15, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-savestate

Description

Grid.prototype.sortColumn = function sortColumn(column, directionOrAdd, add) {

...

Why default typeof column.sort is Array? Whe it is object, then state is ok. First time sorting it is Array and state can not be saved.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the `sortColumn` function in ui grid to understand how `column.sort` is initialized. The issue states that when `column.sort` is an Array, state saving fails, but works when it's an Object. Look at the grid.js or relevant source files to trace the data type of `column.sort` during first sorting. Consider whether this is a bug in the column state serialization or in how sort is set. Since the issue is from 2015 and the repository may be inactive, check recent issues or forks for fixes.