angular-ui/ui-grid

When explicit row height set, mouse wheel scroll doesnt work.

Open

#4,351 opened on Sep 10, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-core

Description

putting an int value in rowHeight produces strange results, I've been using pixel value as rowHeight: '200px'. It looks like getCanvasHeight expects integer value there though so doesnt do anything to see the px value. This causes bad values coming from that function but doing this fixes it:

change:

self.visibleRowCache.forEach(function(row){
  self.$$canvasHeight += row.height;
});

to:

self.visibleRowCache.forEach(function(row){
  self.$$canvasHeight += parseInt(row.height.replace("px", ""));
});

Contributor guide

Tech stack
angularjavascriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is in the code that sums visibleRowCache heights. The fix is to change the line `self.$$canvasHeight += row.height;` to parse integer from `row.height` by removing 'px' suffix. The relevant file is likely in the ui grid source, possibly in the grid rendering module. Review the function that sets row height and the mouse wheel scroll handler to ensure consistency.