angular-ui/ui-grid

ui-grid-selection inaccurate on android/chrome

Open

#4,344 opened on Sep 9, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-selectionhelp wantedneeds: analysis

Description

When using "enableRowSelection: true", left clicking on a row from an android device running the chrome browser, will act weird. By this I mean it will either select the row above or below the one you actually selected, or it will simply unselect the row instantly after clicking on it.

If we now try to use toggleRowSelection() to remove the highlight (assuming we got lucky and it actually selected the row you clicked), the entire table will freak out and infinitely keep switching selects between the actual row and the row above it.

This problem was present on: Samsung Galaxy Tab 3 Lite (Chrome) Samsung Galaxy S6 (Chrome) iPhone 5 (Chrome)

The problem was not present on: Nokia Lumia 930 (Internet Explorer) Desktop/Laptop (FireFox, Chrome, Internet Explorer)

Could anyone look into this once they find the time?

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular basicsTouch event handlingui grid row selection code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the row selection event handling in ui grid, specifically focusing on touch events on Android Chrome. Look at the ui grid source code for row selection (possibly in features/selection.js or similar). Consider adjusting click detection for touch coordinates. Check for existing fixes or discussions in other issues or PRs.
ui-grid-selection inaccurate on android/chrome · angular-ui/ui-grid#4344 | Good First Issue