angular-ui/ui-grid

Tooltips take the cell's filter even when not needed

Open

#4,302 opened on Sep 1, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

Hi, I've tried to setup a cell tooltip for a filtered cell.
I've followed the code in ui-grid and found some issues (https://github.com/angular-ui/ui-grid/blob/fcbafc6c3594be9aa75fa35d69b9bf01bf3925cd/src/js/core/services/gridClassFactory.js#L114).

I have 2 cases in which this is a problem:

  1. I want to filter the cell content, and in a tooltip show the unfiltered content.
  2. I want to enact a different filter on the tooltip (or enact the filter in the tooltip's function).

These 2 use cases are very close to each other and there are several variants I can think of for each.

I've implemented my solution in my app: Set a tooltipFilter property in the colDef that would either be unedfined (to use the cell's filter), a string/function that returns a string (for a filter) or false (for no filter).

What do you think? Is there a better way to do this?

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsui grid cell templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the current tooltip implementation in ui grid, particularly in gridClassFactory.js around line 114 where cell filters are applied. The issue proposes adding a `tooltipFilter` property to colDef. Review the comments for additional context. Implement the property to allow false, a string filter name, or a function, ensuring backward compatibility.
Tooltips take the cell's filter even when not needed · angular-ui/ui-grid#4302 | Good First Issue