angular-ui/ui-grid

grid.selection.selectedCount not refresh on clearSelectedRows()

Open

#4,300 opened on Sep 1, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Almost everything is in the title : when the function clearSelectedRows() is called, the property grid.selection.selectedCount is not reset to 0. So the count is not right, and when you select rows again, the former count is increased. So you can have 23 selected rows on a grid which contains only 20 elements. I'm using version 3.0.0-rc20. Please let me know if this issue has been fixed on a more recent version.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of AngularFamiliarity with ui grid selection API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the `clearSelectedRows()` function in the selection feature module of ui grid. The `selectedCount` property likely needs to be reset to 0 within that function. Check the source code in `src/features/selection/` or similar directories. Existing comments may indicate similar issues or patches. The fix is likely a one line change to reset the count.