angular-ui/ui-grid

height calculation error produces extra white space below the last row, with option enableFiltering: true

Open

#4,275 opened on Aug 26, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Here is my plunker: http://plnkr.co/edit/WYZUxZHFGpa3RCaAyJDy?p=preview

When enableFiltering: true, the height calculation is wrong.

In this particular case, changing the grid height to 181px works, that's 4px off. I am thinking I need to hard override the grid height as a workaround.

Contributor guide

Research direction
Investigate the height calculation logic in the grid, specifically focusing on the filter row height when enableFiltering is true. Look at the CSS and the JavaScript method that computes grid height, and trace why an extra 4px whitespace appears below the last row.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70