angular-ui/ui-grid

height calculation error produces extra white space below the last row, with option enableFiltering: true

Open

#4,275 opened on Aug 26, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Here is my plunker: http://plnkr.co/edit/WYZUxZHFGpa3RCaAyJDy?p=preview

When enableFiltering: true, the height calculation is wrong.

In this particular case, changing the grid height to 181px works, that's 4px off. I am thinking I need to hard override the grid height as a workaround.

Contributor guide

Tech stack
javascriptangularhtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Angular basicsUI Grid codebase structureCSS box modelJavaScript debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the grid height calculation logic in the ui grid source code, particularly the functions that compute total height based on row heights and enableFiltering. Review the plunker to reproduce the issue. Look for any CSS or JavaScript that adds extra space when the filter row is enabled. Check if there are any existing PRs or comments that address similar height issues.