angular-ui/ui-grid

Issue in explicitly setting row as selected

Open

#4,239 opened on Aug 21, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedworkaround

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Initially when UI grid loads the data, I want to show first row as selected. I found one issue - I am calling this public API
$scope.gridApi.selection.selectRow(row);

This method internally calls toggleRowSelection and multiSelect, noUnselect are false in my case. toggleRowSelection: function (grid, row, evt, multiSelect, noUnselect)

var selected = row.isSelected; // undefined afer loading the grid

In the above method, i am able to see selected value is "undefined" after initializing the grid. Therefore, code goes into following if block and which clears the row. if (!multiSelect && !selected) However, the code should first check whether is it undefined or not. Either, there should be some different API for selecting row. Using togle is issue.

Contributor guide

Research direction
Inspect the toggleRowSelection function in the selection service to handle the case where row.isSelected is undefined. Consider adding a check for undefined before the if condition.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60