angular-ui/ui-grid

Column menu doesn't close on click out side when navigation feature (cellnav) is activated

Open

#4,194 opened on Aug 14, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

As the headline said, you can test it also in the tutorial: http://ui-grid.info/docs/#/tutorial/202_cellnav

  1. Activate the cellNav feature
  2. click on a cell to focus it
  3. click on a headermenu
  4. don't close the header menu with the close button -> try to select another cell -> in the example without cellnav, the column menu get close when you click outside of the menu. -> when navigation is on and you have the filter row visible and click on the filter, then the column menu will close correctly, because there is no cellnav on the filter row

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular basicsui grid knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is that the column menu does not close when clicking outside if cellNav is active. Investigate the interaction between the column menu's close logic and the cellNav module. Look for event listeners in the column menu directive and cellNav directive. A potential fix could involve dispatching a click event or using a global click handler that checks if the clicked element is outside both the menu and the grid cell. Check the source files like 'ui grid/features/cellnav/js/cellnav.js' and 'ui grid/features/column menu/js/column menu.js'.