angular-ui/ui-grid

Pagination includes sub grid in page size

Open

#4,168 opened on Aug 12, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issueneeds: analysis

Description

Hi,

If I select the Page size to display, let's say 5 records, and I have 5 records, each with 2 sub Items, it will display only 3 items on the first level....so it is counting the sub Items in the pagination...not sure if this is the intent, or if it can be set...pls c pic below: image

Contributor guide

Tech stack
angularjavascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of ui grid tree grid conceptsBasic Angular knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The bug is that pagination counts sub grid rows as part of the page size, causing fewer top level rows to display. To fix, locate the pagination logic in the ui grid source code, likely in the pagination service or directive. Examine how the total number of rows is computed when tree grid is enabled. Ensure that only top level rows are considered for pagination, not expanded sub rows. The screenshot shows an example with 5 records each having 2 sub items, resulting in only 3 top level items displayed when page size is 5. Check GitHub code at https://github.com/angular ui/ui grid, focusing on files like 'gridRowBuilder.js' or 'pagination.js'.