angular-ui/ui-grid

Grouping aggregation functions break when grouping by the column they were applied too.

Open

#4,142 opened on Aug 7, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hello, Ive noticed that aggregation functions break when grouping by the column they are applied to. Steps to reproduce:

  1. Visit tutorial 320 here: http://ui-grid.info/docs/#/tutorial/320_complex_grouping
  2. Select 'group' in the column menu for any (or all) of the 'balance' columns

expected result: The column continues to display its aggregated result whether or not it is grouped. actual result: the aggregated column changes to be blank.

now: 3. ungroup the column

expected result: Grouping a column and then ungrouping it should return the grid to the exact state it was in before grouping. actual result: The column remains blank, having grouped it appears to have permanently destroyed its ability to aggregate values inside of it. The only way to restore functionality is to refresh the page.

What I believe is happening: Using the column menu to group an item causes UIgrid to overwrite the custom aggregation function I defined with its own function, but still uses the custom finalizer function. Since I built my finalizer function using knowledge of the aggregation function, it breaks.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS basicsUI Grid APIunderstanding of custom aggregation functions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the UI Grid source code, specifically the grouping and aggregation logic. Look at how the column menu triggers grouping and how it interacts with custom aggregation functions. The bug appears in the tutorial 320 example; reproduce the issue and examine the aggregation function and finalizer. Check if the group function overwrites the aggregation function property. Consider potential fixes such as preserving the custom aggregation function when grouping is toggled.