angular-ui/ui-grid

Angular UI Grid auto complete bug

Open

#4,128 opened on Aug 6, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

I am using AngularJs and ui-grid, and in my grid I am using auto-complete within the Name Column; said that ui-grid-cellNav is enabled for cell navigation, my problem is when I am pressing arrow up and down in the auto-complete it's changing the row in the grid, not the auto-complete items

here is the plunker link http://plnkr.co/edit/1tqcB5noOvuwaLEUCDgC?p=preview

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJSui gridevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the interaction between ui grid's cellNav directive and the autocomplete directive's keydown events. The provided plunker (http://plnkr.co/edit/1tqcB5noOvuwaLEUCDgC?p=preview) demonstrates the issue. The likely fix involves stopping propagation of arrow key events when autocomplete is open. Look at the source code in `src/features/cellnav` and `src/features/edit` for event handling. Consider adding a check in cellNav to not handle arrow keys when an autocomplete dropdown is active.