angular-ui/ui-grid

EditOnFocus with Pinning problem

Open

#4,048 opened on Jul 27, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-cellNavgrid-edithelp wantedtype: bug

Description

I have a grid which combine editOnFocus feature and column pinning. if the grid needs to scroll horizontally for display the cell for editing, the cell is not focused. Plunker example: http://plnkr.co/edit/JbTwQLPSmB7K8a6o7NDr?p=preview

try edit city and then the name, the name will not be focused.

Contributor guide

Tech stack
javascriptangularhtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of ui grid's editOnFocus featureKnowledge of column pinning in ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Reproduce the issue using the provided Plunker (http://plnkr.co/edit/JbTwQLPSmB7K8a6o7NDr?p=preview). The bug occurs when editing a cell in a pinned column and then trying to edit another cell that requires horizontal scrolling. Focus is not transferred correctly. Investigate the grid's focus management logic, particularly how it handles scroll events and repositions the edit input. Look at the source files related to editOnFocus and column pinning, such as 'ui grid edit.js' and 'ui grid pinning.js'. Check if there is a regression or missing handling for scroll adjustment. The issue has only one comment (likely the author), so no additional maintainer input. Consider if the fix requires adjusting the scroll offset before applying focus.