angular-ui/ui-grid

Remove 'replace' from directives

Open

#4,024 opened on Jul 21, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issueneeds: decisiontype: enhancement

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Two major reasons:

  • It is deprecated and will be removed in Angular 2.0 https://docs.angularjs.org/api/ng/service/$compile
  • It creates more problems than it is worth.
    • For example: If you try to create a stacked directive and start adding classes to an element they end up getting removed because the dom element gets removed.

Contributor guide

Research direction
Identify all directives that have a 'replace' property and delete that property. Then run the test suite to ensure nothing breaks.
Tech stack
javascriptangular
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75