angular-ui/ui-grid

Remove 'replace' from directives

Open

#4,024 opened on Jul 21, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issueneeds: decisiontype: enhancement

Description

Two major reasons:

  • It is deprecated and will be removed in Angular 2.0 https://docs.angularjs.org/api/ng/service/$compile
  • It creates more problems than it is worth.
    • For example: If you try to create a stacked directive and start adding classes to an element they end up getting removed because the dom element gets removed.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSDirectives
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
This issue involves removing the deprecated 'replace' property from all AngularJS directive definitions in the ui grid codebase. Look for occurrences of 'replace: true' or 'replace: false' in directive definition objects. Ensure tests are updated accordingly. The issue is from 2015, so verify if the codebase still uses AngularJS version that supports it. Refer to the AngularJS documentation on $compile for context.