angular-ui/ui-grid

Memory leak on ui-grid-menu showMenu

Open

#3,972 opened on Jul 13, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
help wantedseverity: memory leaktype: bug

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

On ui-grid-menu.js, there are 2 methods showMenu and hideMenu that are added to scope but also are added to some self variable that happens to be the ``window` object.

The problem is that in a spa app, navigating away from the list, on the window object that is not going to be destroyed, the 2 functions will remain with the scope as context variable, so all the grid objects, columns, rows will be carried through the rest of the journey.

The 2 functions seem to be used only through scope, so no need for them on the ``window` ... at least to the point I got now.

Contributor guide

Research direction
Inspect the showMenu and hideMenu functions in ui grid menu.js. Confirm they are attached to the window object unnecessarily and remove the window assignment while keeping the scope attachment.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60