angular-ui/ui-grid

When enableGroupHeaderSelection is false, can we not display the check icon on the group header row?

Open

#3,861 opened on Jun 24, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-grouping

Description

When enableGroupHeaderSelection is false, the user cannot select the row. This might be confusing because there still is an icon for the checkbox, just one that does nothing.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the template or directive responsible for rendering the group header row in ui grid. The checkbox icon is likely rendered conditionally based on the `enableGroupHeaderSelection` property. Examine the existing code in the grid header component (e.g., files like uiGridHeader or groupHeader) to understand how the checkbox is shown. Then modify the logic to hide the checkbox when the flag is false. Consider opening a PR with the minimal change.