angular-ui/ui-grid

scrollToIfNecessary sets bottomBound as NaN

Open

#3,849 opened on Jun 24, 2015

View on GitHub
 (9 comments) (1 reaction) (1 assignee)JavaScript (2,496 forks)batch import
help wantedneeds: analysis

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In ui-grid - v3.0.0-rc.22 I am trying to execute the scrollTo functionality. When I hit line 5280:

var bottomBound = self.renderContainers.body.prevScrollTop + self.gridHeight - self.renderContainers.body.headerHeight - self.footerHeight - self.scrollbarWidth;

the value for 'self.renderContainers.body.headerHeight' is undefined which causes the 'bottomBound' to be set to 'NaN'. It seems like the value used here should instead be 'self.headerHeight' which is used to set the 'topBound' on line 5270.

Am I either incorrect in that the value should be switched or am I doing something else that causes self.renderContainers.body.headerHeight to be 'undefined'?

Contributor guide

Research direction
Verify the property used in scrollToIfNecessary and consider replacing self.renderContainers.body.headerHeight with self.headerHeight to avoid NaN.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70