angular-ui/ui-grid

Refactor removed ability to handle Enter & arrow keys on grid

Open

#3,805 opened on Jun 18, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Refactor: https://github.com/angular-ui/ng-grid/pull/3120 says this:

The problem is that viewPortKeyDown does not get called for navigation keystrokes (specifically Enter and Left/Right Arrow). Previous to this refactor, we could attach an ng-keydown in a cell template to handle these keys.

We desperately need this, as the Enter key lets us submit the form the user is on and the left/right arrow keys let us scroll the grid immediately, irrespective of which column has focus.

I can try to submit a bug fix if that's preferred, though I might not implement it properly...

Contributor guide

Research direction
Examine PR #3120 to understand the refactor changes, then trace the viewPortKeyDown handler and cellNav API to determine why the keydown events for Enter/Arrow keys are not being fired for navigation. Explore adding keydown event capturing within the cell template or extending viewPortKeyDown to include these keys.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50