angular-ui/ui-grid

Select All does not persist across all Pagination pages

Open

#3,749 opened on Jun 11, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-coretype: bug

Description

Hi,

I have a grid with pagination. If I check the selectAll check box on page number1 of the grid and move to next page of the grid, selectedAll is still check whereas none of the items are selected in page two of the grid.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsui grid usagepagination concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the selection service in ui grid, specifically how the selectAll state is managed across page changes. Look at files like 'features/selection/js/selection.js' and 'features/pagination/js/pagination.js'. Review the two comments on the issue for additional context. The fix likely involves resetting the selectAll flag on page change events.