angular-ui/ui-grid

Grouping breaks Column Header Height for deferred columnDefs generation

Open

#3,609 opened on May 27, 2015

View on GitHub
 (4 comments) (1 reaction) (1 assignee)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

http://plnkr.co/edit/u6LBOx?p=preview As you can see in this demo if the column header height is wrong when the grouping directive is added to the grid. This is only a problem when the column defs aren't there when the grid options are loaded. Example:

$timeout(function(){
  var newColumnDefs = [
    { name:'firstName', field: 'first-name', displayName: 'First Name'},
    { name:'1stFriend', field: 'friends[0]', displayName: '1st Friend'},
    { name:'city', field: 'address.city', displayName: 'City'},
    { name:'getZip', field: 'getZip()'}
  ];
  $scope.gridOptions.columnDefs = newColumnDefs;
}, 500);

This problem is not there for the grid without the grouping directive.

When you perform the grouping action the headers appear correctly however when you ungroup they return to their broken state. OS: Mac OSX Browser: Chrome Build: v3.0.0-rc.21-d68dcc6 - 2015-05-27 screen shot 2015-05-27 at 2 19 41 pm

Contributor guide

Research direction
Investigate the timing when columnDefs are set after grid initialization and how the grouping directive recalculates header heights. Look at the grid's header height calculation logic and the grouping plugin's interaction with deferred column definitions. Check if there is a missing recalculation trigger when columnDefs are updated.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
AngularJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60