angular-ui/ui-grid

Rewrite notifyDataChange to be a grid eventing process instead

Open

#3,603 opened on May 27, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
good first issuetype: chore

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Thinking about this, there's no reason this couldn't use grid.raise and grid.on instead. And that'd be much more in pattern, avoiding having a special thing that confuses people.

It shouldn't be overly hard, it's largely a pattern-based search and replace thing.

Contributor guide

Research direction
Understand how grid.raise and grid.on are used elsewhere in the codebase. Find all usages of notifyDataChange and replace them with equivalent grid event calls.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
AngularJSui grid eventing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70