angular-ui/ui-grid

Column pinning is malfunctioned when Chrome not zoom to 100%

Open

#3,560 opened on May 22, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedtype: bug

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I tested the official example of column pinning in http://angular-ui.github.io/ng-grid/ on Chrome browser. It could only work properly on zoom view 100%. Once changed to 90% or 110% then pinning got malfunctioned.

During testing, I found calculation of pinned column's new left while scrolling will occur floating point under Chrome. But domUtilityService.setColLeft only search integer value to make replacement.

Test Environment: OS: Win7 64bit, Browser: Chrome 43.0.2357.65 m

Contributor guide

Research direction
Investigate the floating point calculation in domUtilityService.setColLeft when Chrome zoom is not at 100% and ensure integer comparisons work with floating point values.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65