angular-ui/ui-grid

row edit with uneditable cell doesn't fire save event...

Open

#3,542 opened on May 20, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-row-edithelp wantedtype: bug

Description

Hello again,

Please see this plnkr:

http://plnkr.co/edit/Oj0IeJubS7biWf9bhgVI?p=preview

Take a look at the first grid:

  1. Press the add row button.
  2. Edit the name and press tab
  3. Edit the gender and press tab
  4. Edit the age and press tab
  5. Notice that the grid saves the data...

Repeat the same steps in the second grid... The only difference is that the "age" column is not editable. Notice that the row save event doesn't fire after tabbing away from the bottom/rightmost cell if it's not editable.

I've tried this same code inserting the by inserting the blank item at the top and it works in both cases...

Am I doing something incorrectly here or is this a bug?

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsui grid knowledgeunderstanding of row edit lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the ui grid edit module, specifically the logic for triggering row save events when tabbing out of the last editable cell. Compare the behavior of the first grid (all cells editable) to the second grid (age column uneditable). Look at the event handling in the edit feature, possibly in GridEdit directive or related controllers. Check for any condition that prevents the save event when the bottom rightmost cell is not editable.