angular-ui/ui-grid

[BUG]: RTL column menu wrong positioning

Open

#3,460 opened on May 9, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuetype: bug

Description

Here's the plnkr: http://plnkr.co/edit/MAjaBO3Bpe3mf04JxWpo?p=preview Simply open one of the column menus and see it doesn't show in the right place.

Using this code in the repositionMenu function:

if (column.grid.isRTL()){
        left = positionData.left + positionData.parentLeft+ positionData.width;
}

Seems to fix this.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptAngular (1.x)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the `repositionMenu` function in the ui grid source code, likely in a grid menu related file. The bug is that column menus are mispositioned in RTL mode. The suggested fix adds an `if (column.grid.isRTL())` condition to adjust the `left` variable by adding `positionData.width`. Review the current implementation and apply the fix, then test with RTL enabled. No existing pull requests are linked.