angular-ui/ui-grid

[BUG]: RTL column menu wrong positioning

Open

#3,460 opened on May 9, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issuetype: bug

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Here's the plnkr: http://plnkr.co/edit/MAjaBO3Bpe3mf04JxWpo?p=preview Simply open one of the column menus and see it doesn't show in the right place.

Using this code in the repositionMenu function:

if (column.grid.isRTL()){
        left = positionData.left + positionData.parentLeft+ positionData.width;
}

Seems to fix this.

Contributor guide

Research direction
Apply the suggested fix in the `repositionMenu` function to handle RTL positioning.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80