angular-ui/ui-grid

Multiselect with shift in IE 11

Open

#3,392 opened on Apr 30, 2015

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
Browser IEhelp wantedtype: bug

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Using mulitselect with shift on the grid in IE gives also select other random dom elements, which gives a buggy feeling.

Tested on http://ui-grid.info/docs/#/tutorial/210_selection and ui-grid 3.0-RC21 in our project.

Tested with IE11, version number 11.0.9600.17728, update 11.0.18.

Steps to reproduce:

  1. Open http://ui-grid.info/docs/#/tutorial/210_selection in IE11.
  2. Select one element in the list by clicking the left checkbox
  3. Press shift, and click on an other element in the list

This happened when I used shift to select multiple elements; image

I'am trying to apply the following workarround, and it seems to work. Hopefully it won't break anything else

<div ui-grid="gridOptions" ui-grid-selection ui-grid-resize-columns ng-mousedown="$event.shiftKey && $event.preventDefault()">
});

Contributor guide

Research direction
Investigate the shift key handling in the selection feature. Check the ng mousedown event and ensure that shift+click does not trigger selection of random DOM elements. Look at the workaround using $event.preventDefault() and apply a proper fix in the grid directive.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAngular basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65