angular-ui/ui-grid

3.0.0-RC.20 row header got focused when tab off the previous row

Open

#3,389 opened on Apr 30, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

image

When tab off the last cell of previous row, the focus is on the row header since RC. 20. I changed the function setTabEnabled() { $elm.find('div').attr("tabindex", -1); } to be function setTabEnabled() { $elm.find('div').attr("tabindex", 0); }

Then it correctly focused on the first cell but not row header.

Is this designed on purpose?

Contributor guide

Research direction
Examine the setTabEnabled function that controls tabindex for row headers and cells, and verify the expected tab order behavior. Trace the focus event handling to ensure the first cell receives focus when tabbing from the previous row.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Angulartabindex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65