angular-ui/ui-grid

3.0.0-RC.20 row header got focused when tab off the previous row

Open

#3,389 opened on Apr 30, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

image

When tab off the last cell of previous row, the focus is on the row header since RC. 20. I changed the function setTabEnabled() { $elm.find('div').attr("tabindex", -1); } to be function setTabEnabled() { $elm.find('div').attr("tabindex", 0); }

Then it correctly focused on the first cell but not row header.

Is this designed on purpose?

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsDOM tabindexUI Grid keyboard navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the setTabEnabled function to understand why tabbing from the last cell of a row causes focus to move to the row header instead of the first cell of the next row. The user's workaround suggests changing tabindex from 1 to 0 on div elements, but this may have side effects. Review the grid's keyboard navigation logic and check for any design decisions regarding row header focus. Examine the issue's reproduction and consider if this is a regression. See the original issue for details.