angular-ui/ui-grid

In RC21, uiGridEventEndCellEdit triggered after grid data updated

Open

#3,384 opened on Apr 29, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

So there's no way to determine if a value actually changed or not. In RC20, the event was triggered before the grid data was updated so it was possible to check the row data passed in with the event to the data that currently exists in the grid.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of AngularJSFamiliarity with ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the ui grid source code, particularly the cell editing module. Find where uiGridEventEndCellEdit is emitted. The issue says in RC21 it fires after data update. Compare with RC20 code if available. Consider moving the event emission before the data update, or adding a parameter that indicates whether the value changed. Check the assignee's branch or any related commits. Also review the single comment on the issue for any additional context.