angular-ui/ui-grid

Unable to disable vertical Scroll [since v3.0.0-rc.20-89461bc]

Open

#3,370 opened on Apr 27, 2015

View on GitHub
 (4 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

This commit 89461bc broke the ability to disable vertical scrolling.

Last unstable version (NOT WORKING): http://plnkr.co/edit/k46LqpiBc1cesOP8xdIM?p=preview

Unstable version v3.0.0-rc.20-d4a784f - 2015-04-21 (WORKING): http://plnkr.co/edit/35szFnzVSPGinvzJgR8y?p=preview

Also, the scrolling cannot be disabled if the grid has already been scrolled.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui gridCSS overflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the commit 89461bc that introduced the regression. Compare the working and non working plnkr examples to identify the CSS or JavaScript change that disabled the ability to disable vertical scrolling. The fix likely involves reverting or adjusting the scroll disable logic in ui grid's grid definition or CSS. Check the ui grid source code for the scroll related options.