angular-ui/ui-grid

Sorting works inconsistently , when table column contains null/undefined/empty values

Open

#3,360 opened on Apr 24, 2015

View on GitHub
 (15 comments) (1 reaction) (1 assignee)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I observed that the handlenulls method present in all sort methods(exmaple : alphasort) is working inconsistently. It is unable to handle the empty values in present in the table while sorting. Note - I am using Sort Ascending and Sort Descending options and not the header options.

Scenario - When a column containing null values is sorted -

  1. Step 1 : Ascending order - null values are pushed at the bottom, values gets sorted correctly
  2. Step 2 : Descending order - nothing happens ,sorting does not work.

Contributor guide

Research direction
Inspect the 'handlenulls' method in the alphaSort (or similar) sorting functions in ui grid source code. Trace the sorting logic to understand why descending sort fails after ascending sort when null values are present. Ensure null handling works consistently for both ascending and descending orders.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65