angular-ui/ui-grid

1px padding-top on ui-grid-canvas

Open

#3,275 opened on Apr 14, 2015

View on GitHub
 (4 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

1px padding was added to the top of the ui-grid-cavas in https://github.com/angular-ui/ng-grid/commit/040a5ee1acc1fdeda6a466fbe05d242f8775ef18. When you scroll the grids viewport to the top there is a 1px gap between the headers and the start of the grids rows.

It's not very noticeable with the grids default styles but if you change them, specifically if you make the cell borders a dark colour, the gap is very apparent.

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is caused by a 1px padding top added in commit 040a5ee1. The fix likely involves removing or adjusting that padding. Examine the ui grid canvas CSS class in the source code. Ensure that removing the padding does not cause other visual regressions, especially with scrolling behavior.
1px padding-top on ui-grid-canvas · angular-ui/ui-grid#3275 | Good First Issue