angular-ui/ui-grid

perf(refreshCanvas): Running too often?

Open

#2,139 opened on Nov 18, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In pulling some simple CPU profiles it seems like a disproportionate amount of time is spent recalculating header heights when they haven't changed... There should be a way to skip this while scrolling as it's unneeded.

However we can't simply do the calculation once and be done because toggling grid options could theoretically alter header height.

Contributor guide

Research direction
Profile the canvas refresh function using browser dev tools to identify when header height recalculations occur and implement a conditional skip based on unchanged grid options.
Tech stack
javascript
Domain
frontend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60