angular-ui/ui-grid

Request: Dynamic height based on row count

Open

#1,735 opened on Oct 6, 2014

View on GitHub
 (74 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
Hi-Pri Bughelp wantedtype: enhancement

Description

At the moment we solve this by changing the container height based on the number of rows in the grid but it would be nice to be able to tell ui-grid to not be constrained by a specific height so that all rows are visible without the grid itself having to scroll (its fine if the page needs to be scrolled).

While this can be done by setting the container height to something massive, it leaves lots of bordered whitespace which looks bad.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the ui grid's height calculation logic, specifically how the grid container height is computed and how rows are rendered. Look at the existing workaround mentioned in the issue (changing container height based on row count) and consider implementing an option to automatically adjust height to fit all rows without internal scrolling. Review comments in the issue for proposed solutions or discussions on API design. Key files to examine: 'grid.js', 'gridUtil.js', and any CSS files controlling grid height and overflow.