angular-fullstack/generator-angular-fullstack

Incorrect usage of Promise and safeCb in code using auth.service.ts (canary)

Open

#2682 opened on Dec 30, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import
good first issue

Description

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 5.0.0-beta.3
Node v8.9.3
npm 5.6.0
Operating System Ubuntu 16.04
Item Answer
Transpiler TypeScript
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB MongoDB
Auth Y

Example

auth.service.ts

    changePassword(oldPassword, newPassword, callback) {
        return this.UserService.changePassword({id: this.currentUser._id}, oldPassword, newPassword)
            .toPromise()
            .then(() => {console.log("success"); safeCb(callback)(null)})
            .catch(err => {console.log("error"); safeCb(callback)(err)});
    }

Then in settings.component.ts you do:

  changePassword(): void {
    this.submitted = true;
    return this.AuthService.changePassword(this.oldPassword, this.password)
      .then(() => {
        // success message
      })
      .catch(err => {
        // incorrect password message
      });
  }

Here // success message is always displayed because safeCb returns undefined.

Contributor guide

Tech stack
angulartypescriptnodejsexpressmongodb
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of AngularTypeScriptpromises
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review auth.service.ts and settings.component.ts files. The issue shows that `changePassword` returns undefined due to `safeCb` usage, causing the component's success callback to always execute. The fix should ensure the promise chain correctly propagates results or errors without using `safeCb` in a way that returns undefined. Consider removing `safeCb` or adjusting the service to return a promise that resolves/rejects appropriately.