angular-fullstack/generator-angular-fullstack

Enhancement: Remove serve-favicon dependency

Open

#2,640 opened on Sep 28, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import
Help Wantedchoreenhancement

Description

The philosophy behind the serve-favicon module is rather outdated, almost nobody knows or cares about creating .ico files. Everyone just puts .png or .gif files now (Mac and iOS ignore .ico anyway). But omitting the favicon.ico file makes the app crash in production environment because of the serve-favicon dependency.

Please consider removing this module and adding support for the modern icons required by the newer OSs, by adding these lines in _index.html:

  <link rel="icon" type="image/png" href="/favicon.png">
  <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="96x96" href="/favicon-96x96.png">
  <link rel="apple-touch-icon" href="/favicon_120_retina.png">
  <link rel="apple-touch-icon" sizes="152x152" href="/favicon_152_retina.png">
  <link rel="apple-touch-icon" sizes="167x167" href="/favicon_167.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/favicon_180.png">

Contributor guide

Tech stack
javascriptnodejsexpressangularhtmlcss
Domain
frontendbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic HTML knowledgeNode.js project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue requires removing the serve favicon dependency from the project's package.json and updating the index.html to include the provided favicon link tags. The file index.html is likely in the app's template directory. No linked PRs or comments indicate any ongoing work. The main task is to update the template and configuration.
Enhancement: Remove serve-favicon dependency · angular-fullstack/generator-angular-fullstack#2640 | Good First Issue