angular-fullstack/generator-angular-fullstack

Should client/app/admin and account be full components?

Open

#2490 opened on Feb 4, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import
Help Wanted

Description

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.2
Node 6.9.4
npm 4.1.2
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize 4.0.0-2 / PostgreSQL 9.6.1
Auth Y

account(auth) and admin(auth) are implemented as loosely coupled controllers. Their implementation differs from the generated main component (which is an AngularJS component). Also, possibly change their controllerAs to $ctrl from vm.

What are your thoughts about making admin, login, settings, and signup into full AngularJS components? This would improve consistency as well as lay the foundation for those moving to 2.0.

Contributor guide

Tech stack
javascriptangularnodejsexpresspostgresql
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS component basicsYeoman generator structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the current implementation of admin, login, settings, and signup controllers in the templates/app/client/app/account(auth)/ and admin(auth)/ directories. Compare with the main component example at templates/app/client/app/main/main.component.js. Plan to refactor each controller into a full AngularJS component with its own template and controllerAs '$ctrl'. Ensure consistency with the main component structure.