angular-fullstack/generator-angular-fullstack

Should encryption and hashing functions be converted to be asynchronous?

Open

#2240 opened on Sep 17, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import
Help Wantedenhancement

Description

I noticed the use of the crypto library implements synchronous operations. Should this be dropped for use of asynchronous? Under heavy server load this could lock up the application right?

Contributor guide

Tech stack
javascriptnodejs
Domain
backendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.jsasync/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the use of synchronous crypto functions in the generator's codebase. Look for `crypto.createHash` or similar calls in files that handle encryption or hashing. Propose replacing them with asynchronous counterparts using `crypto.promisify` or `require('crypto').async`. Ensure the change does not break existing functionality and consider that the generator may run synchronously during generation, so evaluate if async is feasible. Check if there are existing PRs or maintainer comments on this topic.