angular-fullstack/generator-angular-fullstack

Error with PUT with Sequelize Backend

Open

#2,180 opened on Aug 26, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,268 forks)batch import
Help WantedV4bug

Repository metrics

Stars
 (6,134 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.0.1
Node 4.4.5
npm 3.10.5
Operating System OS X 10
Item Answer
Transpiler Babel
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB SQL
Auth N

Hey,

It appears the Mocha PUT tests / Upsert Functionality for the Sequelize backend are broken.

The test expects the object back when according to the Sequelize documentation it only return a true or a false. http://docs.sequelizejs.com/en/latest/api/model/#upsertvalues-options-promisecreated

Although in my case I get undefined... which causes it to not return anything and breaks the backend route entirely. I think it might be because I'm using Postgres... I was able to modify the backend code fine to get around it. but figured I should raise it anyways.

Contributor guide

Research direction
Investigate the Mocha PUT test for Sequelize upsert; ensure the test expects the correct return value (true/false) instead of the created object. Modify the backend route if needed to handle the return value.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpmGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55