andywer/use-inline-memo

deps default to []

Open

#4 opened on Aug 31, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (3 forks)github user discovery
enhancementhelp wantedquestion

Repository metrics

Stars
 (164 stars)
PR merge metrics
 (Avg merge 1d 2h) (2 merged PRs in 30d)

Description

Awesome package. Seriously, it should be part of React core! Suggestion: Instead of: memo.textChange(event => setValue(event.target.value), []) accepts this: memo.textChange(event => setValue(event.target.value))

Question: How can you measure that the overhead in memo is faster then a component rerender that justify the use of it?

Great work!

Contributor guide

Research direction
Investigate how to make the deps parameter optional, defaulting to an empty array, while maintaining backward compatibility. Check the existing implementation to understand the current signature and modify it to allow omitting deps.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75