andywer/ava-ts

Should test failure line numbers be accurate?

Open

#8 opened on Jan 28, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (10 forks)github user discovery
help wantedquestion

Repository metrics

Stars
 (115 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Thanks so much for creating ava-ts - it's been really helpful in my projects. I've noticed, however, that wherever ava would normally output line numbers where a test failed, I get completely unrelated code:

  2 tests failed

  rooms.ts › validates room sizes

  /mnt/c/Users/Jack/git/sl-tethers/src/rooms.ts:79

   78:   };
   79:   rules: {         
   80:     rounds: number;

  Rejected promise returned by test. Reason:

  Error (BadRequest) {
    status: 400,
    message: 'You need to pick a room size.',
  }

As you can see from the example, I'm throwing an error within a function, but the highlighted output actually points to a unrelated interface declaration.

Is this a known problem? Do sourcemaps work with ava-ts?

Contributor guide

Research direction
Investigate how ava ts applies source maps when reporting test failure locations. Look at the error handling and stack trace parsing code, and compare with upstream AVA. Check if source map support is missing or incomplete.
Tech stack
typescriptjavascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65