android/uamp

Use URIs for artwork

Open

#235 opened on Jul 12, 2018

View on GitHub
 (3 comments) (7 reactions) (1 assignee)Kotlin (13,191 stars) (3,759 forks)batch import
feature requesthelp wanted

Description

Currently UAMP stuffs Bitmaps into the MediaMetadataCompat objects, but this makes the object use a lot more memory, and forces the use of low resolution images (which are then poorly rendered on large surfaces, such as the background of the lock screen).

The app should use local URIs that point to a ContentProvider and use METADATA_KEY_ALBUM_ART_URI and METADATA_KEY_ART_URI to provide that for use by other components.

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentContentProvider
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the MusicProvider class and MediaIDHelper to understand current artwork handling. Replace the Bitmap based metadata with URI based using METADATA KEY ALBUM ART URI and METADATA KEY ART URI. Ensure a ContentProvider is set up to serve the images. See comments in the issue for additional context.