android/sunflower

Merge prefix/suffix strings into single strings.

Open

#351 opened on Feb 28, 2019

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Kotlin (4,772 forks)batch import
cleanuphelp wanted

Repository metrics

Stars
 (17,785 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Using guidance from Styling internationalized text in Android, it would be better to combine strings such as "watering_next_prefix" and "watering_next_suffix" to a single "watering_next" plural string.

For example:

<plurals name="watering_needs_prefix">
    <item quantity="one"><b>Watering needs:</b> <i>every day</i></item>
    <item quantity="other"><b>Watering needs:</b> <i>every %d days</i></item>
</plurals>

It would certainly also be fine to use the guidance under "Complex text styling with Annotation", but that's more of a stretch goal. :)

Contributor guide

Research direction
Look for strings like 'watering next prefix' and 'watering next suffix' in res/values/strings.xml and similar locale files. Combine them into a single plural resource named 'watering next' using the <plurals> tag as shown in the example. Refer to the linked Medium article for styling internationalized text in Android.
Tech stack
kotlinandroid
Domain
localization
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android string resourcesPlurals in XML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85