android/nowinandroid

[Bug]: Splashscreen theme doesn't change after switching the color theme

Open

#633 opened on Mar 22, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Kotlin (4,404 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (21,223 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

Changing the theme from the application settings does not update the theme used on the splash screen.

Steps to reproduce:

  • When using a light system theme
  • Tap on the settings icon and set the application theme to dark
  • Close the application, start it again (with the cold start) and note the splash screen

Expected result: Splash screen should be in dark mode

Actual result: Light splash screen switches to a dark screen of the application.

I think that UiModeManager#setApplicationNightMode should also be called on saving the theme settings as it is described in "Implement dark theme"

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
The issue suggests that UiModeManager.setApplicationNightMode() should be called when saving theme settings. Look into the settings persistence code (likely in a ViewModel or preferences) and the splash screen initialization (e.g., in the Activity or Application class). Confirm if the theme change is applied to the application context before the next cold start. Check comments for any maintainer guidance or additional context.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
familiarity with Android theme systembasic Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50